War Historian's last ability starts to apply as soon as it's declared as an attacker that's attacking a battle, and it applies for the entire turn. It doesn't matter what happens to the battle after that point.